Skip to content

fix: show loading indicator instead of "No workspaces yet" (#44) #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

fix: show loading indicator instead of "No workspaces yet" (#44) #80

merged 1 commit into from
Apr 11, 2025

Conversation

Schmak
Copy link
Contributor

@Schmak Schmak commented Apr 11, 2025 •
edited by matifali
Loading

Closes #44

@matifali matifali requested a review from fioan89 April 11, 2025 13:59
matifali
matifali approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@matifali matifali left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton for the contribution. Can the loading message be customized? i.e., show Loading workspaces... instead of Loading environments...

@matifali matifali merged commit c616981 into coder:main Apr 11, 2025
5 checks passed
@Schmak
Copy link
Contributor Author

Schmak commented Apr 15, 2025

I've created a dedicated issue (TBX-14526) to make the loading message customizable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fioan89 fioan89 fioan89 approved these changes

@matifali matifali matifali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initial page shows "no workspaces" instead of "loading" indicator
3 participants
@Schmak @fioan89 @matifali